[lldb][test] Run calling-conventions-arm.test with native PDB reader as well #152670
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…also Also, actually check the arm32 output. Lucky for us, it does work. Separated the lines a bit too so they are easier to read.
|
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) ChangesAnd actually check the arm32 output. Lucky for us, it does work. Separated the lines a bit too so they are easier to read. Full diff: https://github.com/llvm/llvm-project/pull/152670.diff 1 Files Affected:
diff --git a/lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test b/lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test
index 7dabf9157d47e..8b0b5b665274d 100644
--- a/lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test
+++ b/lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test
@@ -1,7 +1,12 @@
REQUIRES: target-windows, lld, (target-arm || target-aarch64)
+
RUN: %build --compiler=clang-cl --arch=32 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cpp
+RUN: lldb-test symbols -dump-ast %t.exe | FileCheck %s
+RUN: env LLDB_USE_NATIVE_PDB_READER=1 lldb-test symbols -dump-ast %t.exe | FileCheck %s
+
RUN: %build --compiler=clang-cl --arch=64 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cpp
RUN: lldb-test symbols -dump-ast %t.exe | FileCheck %s
+RUN: env LLDB_USE_NATIVE_PDB_READER=1 lldb-test symbols -dump-ast %t.exe | FileCheck %s
CHECK: Module: {{.*}}
CHECK-DAG: int (*FuncCCallPtr)();
|
Nerixyz
reviewed
Aug 8, 2025
| RUN: %build --compiler=clang-cl --arch=64 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cpp | ||
| RUN: lldb-test symbols -dump-ast %t.exe | FileCheck %s | ||
| RUN: env LLDB_USE_NATIVE_PDB_READER=1 lldb-test symbols -dump-ast %t.exe | FileCheck %s |
There was a problem hiding this comment.
Nice, just realized I didn't need to rename the built executables for 32/64 bit in the other test.
|
You would have done it in the other PR, and that's approved, so I'll just merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And actually check the arm32 output. Lucky for us, it does work.
Separated the lines a bit too so they are easier to read.
Follow up to #152580.